-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds timeout for initial element. #36
Conversation
Will do. |
I can confirm that NVDA now catches the first speech string on Win7 FF, Chrome. JAWS does not. But more seriously, I cannot walk at all using that branch. Do I need to merge other branches into this? |
FWIW, merging the other PRs locally did not help with the broken walker (though I get earcons so the walker must think it's at an edge) |
I just realized that JAWS did not have the initial-speech-string problem in the past :-( On Wind 10, JAWS only voices the initial speech string on Chrome. |
Hm... I think the support matrix is wrong and JAWS did not voice the initial speech in FF on Win 10. At least I can't get it to with the current main branch. |
Were there changes to SRE? |
Walker should work. It works for me at least. |
Apart from the bug fix for the embellished fences, there were no changes to SRE. |
The walker does not work for me on any browser or OS anymore (on https://mathjax.github.io/MathJax-RespEq/Semantics-Lab/Semantics-Lab-TeX.html) |
FWIW, with or without screenreaders it does not work. The same applies to the |
It works perfectly fine for me. On all branches. Sorry I am at a loss, as I am not sure where I could start the debugging. |
Just tried Chrome and Safari on the missus's MacBook. Both worked fine. |
D'oh! Of the highest order. I was stuck on the dummy walker :-( Please excuse my total failure. Will test properly now... |
I did some initial tests on Win8.1 using IE11, FF, Chrome. This solves the initial speech string bug in NVDA and works with JAWS as well. FWIW, the NVDA "sometimes lose first item in level" bug still persists, as does the JAWS "I start with lots of blanks until I magically stop doing that". The earcon works with NVDA on FF and Chrome but I couldn't get it to work with JAWS on either (and the ogg won't work anywhere else). Will test more tomorrow. |
We can certainly change the earcon to something else. mp3 is probably a good alternative, but we may need to do some browser sniffing re FF and Opera (https://en.wikipedia.org/wiki/HTML5_Audio). |
This now has a selective timeout for Chrome & PC. |
Will test this now. FYI the current PRs are diverging.
|
Preliminary summary (without WindowsXP, see above): this branch fixes NVDA's Chrome issues but no other issue. On the bright side, I didn't spot any regressions. |
In case it wasn't clear, I think it's ready to merge. |
Adds timeout for initial element.
That could take care of the initial message problem. It was indeed a timing issue.
Tested with Win7/IE10/NVDA.
@pkra could you please have a look at other combinations?