Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds timeout for initial element. #36

Merged
merged 2 commits into from
Dec 8, 2015
Merged

Adds timeout for initial element. #36

merged 2 commits into from
Dec 8, 2015

Conversation

zorkow
Copy link
Member

@zorkow zorkow commented Nov 27, 2015

That could take care of the initial message problem. It was indeed a timing issue.
Tested with Win7/IE10/NVDA.
@pkra could you please have a look at other combinations?

@pkra
Copy link
Contributor

pkra commented Nov 27, 2015

Will do.

@pkra
Copy link
Contributor

pkra commented Nov 28, 2015

I can confirm that NVDA now catches the first speech string on Win7 FF, Chrome. JAWS does not.

But more seriously, I cannot walk at all using that branch. Do I need to merge other branches into this?

@pkra
Copy link
Contributor

pkra commented Nov 28, 2015

FWIW, merging the other PRs locally did not help with the broken walker (though I get earcons so the walker must think it's at an edge)

@pkra
Copy link
Contributor

pkra commented Nov 28, 2015

I just realized that JAWS did not have the initial-speech-string problem in the past :-(

On Wind 10, JAWS only voices the initial speech string on Chrome.

@pkra
Copy link
Contributor

pkra commented Nov 28, 2015

Hm... I think the support matrix is wrong and JAWS did not voice the initial speech in FF on Win 10. At least I can't get it to with the current main branch.

@pkra
Copy link
Contributor

pkra commented Nov 28, 2015

Were there changes to SRE?

@zorkow
Copy link
Member Author

zorkow commented Nov 28, 2015

Walker should work. It works for me at least.

@zorkow
Copy link
Member Author

zorkow commented Nov 28, 2015

Apart from the bug fix for the embellished fences, there were no changes to SRE.

@pkra
Copy link
Contributor

pkra commented Nov 29, 2015

The walker does not work for me on any browser or OS anymore (on https://mathjax.github.io/MathJax-RespEq/Semantics-Lab/Semantics-Lab-TeX.html)

@pkra
Copy link
Contributor

pkra commented Nov 29, 2015

FWIW, with or without screenreaders it does not work.

The same applies to the timeout_first_message branch, with or without the other branches merged in.

@zorkow
Copy link
Member Author

zorkow commented Nov 29, 2015

It works perfectly fine for me. On all branches. Sorry I am at a loss, as I am not sure where I could start the debugging.
@dpvc do you have any problems?

@zorkow
Copy link
Member Author

zorkow commented Nov 29, 2015

Just tried Chrome and Safari on the missus's MacBook. Both worked fine.

@pkra
Copy link
Contributor

pkra commented Nov 30, 2015

D'oh! Of the highest order. I was stuck on the dummy walker :-(

Please excuse my total failure. Will test properly now...

@pkra
Copy link
Contributor

pkra commented Nov 30, 2015

I did some initial tests on Win8.1 using IE11, FF, Chrome.

This solves the initial speech string bug in NVDA and works with JAWS as well.

FWIW, the NVDA "sometimes lose first item in level" bug still persists, as does the JAWS "I start with lots of blanks until I magically stop doing that".

The earcon works with NVDA on FF and Chrome but I couldn't get it to work with JAWS on either (and the ogg won't work anywhere else). Will test more tomorrow.

@zorkow
Copy link
Member Author

zorkow commented Nov 30, 2015

We can certainly change the earcon to something else. mp3 is probably a good alternative, but we may need to do some browser sniffing re FF and Opera (https://en.wikipedia.org/wiki/HTML5_Audio).

@pkra pkra mentioned this pull request Dec 1, 2015
@zorkow
Copy link
Member Author

zorkow commented Dec 1, 2015

This now has a selective timeout for Chrome & PC.

@pkra
Copy link
Contributor

pkra commented Dec 2, 2015

Will test this now. FYI the current PRs are diverging.

  • NVDA,
    • Win 7
      • IE10, Firefox. Still missing initial string
    • Win 8.1
      • IE11, Firefox. Still missing initial string.
    • Win 10
      • Firefox. Still missing initial string.
  • JAWS
    • Win 7
      • IE10 unchanged (no voicing).
  • WinXP, ALL, Chrome: can't load from https progressiveaccess (general SSL bug)
  • Ubuntu, Orca, Firefox: still misses initial string
  • Win 10, Edge
    • can only run the lab with dev tools open. lots of errors in the console there from SRE.
  • OSX, Safari, VoiceOver. Still missing initial speech string.

@pkra
Copy link
Contributor

pkra commented Dec 2, 2015

Preliminary summary (without WindowsXP, see above): this branch fixes NVDA's Chrome issues but no other issue.

On the bright side, I didn't spot any regressions.

@pkra
Copy link
Contributor

pkra commented Dec 2, 2015

In case it wasn't clear, I think it's ready to merge.

zorkow added a commit that referenced this pull request Dec 8, 2015
Adds timeout for initial element.
@zorkow zorkow merged commit 4ec8e9a into master Dec 8, 2015
@zorkow zorkow deleted the timeout_first_message branch December 10, 2015 00:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants