Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix elementsByClass of liteAdaptor #403

Closed
wants to merge 1 commit into from
Closed

Fix elementsByClass of liteAdaptor #403

wants to merge 1 commit into from

Conversation

not-fred
Copy link

No description provided.

@dpvc
Copy link
Member

dpvc commented Dec 31, 2019

Sorry for taking so long to get back to you on this.

Thanks for identifying the problem, and for the proposed fix. It certainly looks like I screwed up there pretty badly.

I won't be able to merge the PR as is, because we follow the git-flow model, which means that changes are made to the develop branch, not the master branch, and develop is merged to master only during a release. So your fix would need to be on a branch from develop (not master) and targeted to develop.

Because this is a small fix, I will make a new branch from develop with the changes so that you don't have to be bothered with rebasing your branch. Also, it is better to replace classes.find() by classes.includes() rather than the more complicated !!classes.find(c => x === name), as this was what was intended originally. I will also open an issue so that the PR has an issue that it is tied to.

Thanks again for the contribution. We appreciate it!

@dpvc
Copy link
Member

dpvc commented Dec 31, 2019

I have made PR #416 for this.

@dpvc dpvc closed this Dec 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants