Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix LiteAdaptor's search for elements by class. mathjax/MathJax#2278. #416

Merged
merged 1 commit into from
Jan 3, 2020
Merged

Fix LiteAdaptor's search for elements by class. mathjax/MathJax#2278. #416

merged 1 commit into from
Jan 3, 2020

Conversation

dpvc
Copy link
Member

@dpvc dpvc commented Dec 31, 2019

Fix LiteAdaptor's elementsByClass() function so that it doesn't throw an error on classes.find(name), and actually returns the elements found. Also, fix getElements() to search the given document.

Resolves issue mathjax/MathJax#2278.

@dpvc dpvc requested a review from zorkow December 31, 2019 16:51
@dpvc dpvc mentioned this pull request Dec 31, 2019
Closed
zorkow
zorkow approved these changes Jan 3, 2020
View reviewed changes
Copy link
Member

@zorkow zorkow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

@dpvc dpvc merged commit 3cb0425 into develop Jan 3, 2020
@dpvc dpvc deleted the issue2278 branch January 3, 2020 16:30
@dpvc dpvc added this to the 3.0.1 milestone Mar 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zorkow zorkow zorkow approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.0.1
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dpvc @zorkow