Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update new context menu #505

Merged
merged 24 commits into from
Jul 29, 2020
Merged

Update new context menu #505

merged 24 commits into from
Jul 29, 2020

Conversation

zorkow
Copy link
Member

@zorkow zorkow commented Jun 1, 2020

Not yet ready for review

@dpvc dpvc added this to the v3.1.0 milestone Jun 1, 2020
@zorkow zorkow requested a review from dpvc July 22, 2020 16:50
@zorkow
Copy link
Member Author

zorkow commented Jul 22, 2020

This is now ready for review. There are still two issues:

  1. A layout/display issue of the selection box that needs to be sorted out on the context menu side.
  2. A coordination issue between selection box settings and smart settings for clearspeak. This needs to be sorted at the SRE end (for now).

Both are minor issues. So it is ready modulo version numbers of dependencies.

@dpvc
Copy link
Member

dpvc commented Jul 24, 2020

I've looked through it and tried it out, and it looks good. There is one change to the ui/menu component that is needed, but I have made a PR for that, which should be merged first, and then this one can be merged. I made a corresponding PR for the MathJax-dev repository that allows the lab to work with the new menu code.

@dpvc
Copy link
Member

dpvc commented Jul 24, 2020

I should mention that I'm seeing debug messages from the mj-context-menu code (in selection_box.ts lines 134 and 135) when the explorer is active and you select the expression after exiting the explorer.

I also had trouble getting the highlight options to work (hover and flame). I just may jot be doing it right, but they didn't seem to do anything. If I enabled flame and then reload, I could sometimes get the flame to work, but not always.

Update ui/menu component for new mj-context-menu code
@zorkow
Copy link
Member Author

zorkow commented Jul 29, 2020

I should mention that I'm seeing debug messages from the mj-context-menu code (in selection_box.ts lines 134 and 135) when the explorer is active and you select the expression after exiting the explorer.

I wanted to make one more clean release of the package, after fixing one more layout issue, which will remove the logging, too.

I also had trouble getting the highlight options to work (hover and flame). I just may jot be doing it right, but they didn't seem to do anything. If I enabled flame and then reload, I could sometimes get the flame to work, but not always.

Thanks for spotting this. I can see that, too. What's odd is that the semantic info hoverer that use the same principle work fine. I'll look into that.

@zorkow zorkow merged commit bde6ab8 into develop Jul 29, 2020
@zorkow zorkow deleted the update_new_context_menu branch July 29, 2020 11:14
@zorkow
Copy link
Member Author

zorkow commented Jul 29, 2020

I also had trouble getting the highlight options to work (hover and flame). I just may jot be doing it right, but they didn't seem to do anything. If I enabled flame and then reload, I could sometimes get the flame to work, but not always.

Thanks for spotting this. I can see that, too. What's odd is that the semantic info hoverer that use the same principle work fine. I'll look into that.

I figured out the problem: It is an ordering issue. If hover/flame is on before collapsible is active, the respective explorers contain the old base node and hence don't see the maction elements
(Switching them off/on again solves the problem.)

Switching on collapsible would have to reinitialise the respective hoverers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants