-
Notifications
You must be signed in to change notification settings - Fork 204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update new context menu #505
Conversation
This is now ready for review. There are still two issues:
Both are minor issues. So it is ready modulo version numbers of dependencies. |
I've looked through it and tried it out, and it looks good. There is one change to the |
I should mention that I'm seeing debug messages from the I also had trouble getting the highlight options to work (hover and flame). I just may jot be doing it right, but they didn't seem to do anything. If I enabled flame and then reload, I could sometimes get the flame to work, but not always. |
Update ui/menu component for new mj-context-menu code
I wanted to make one more clean release of the package, after fixing one more layout issue, which will remove the logging, too.
Thanks for spotting this. I can see that, too. What's odd is that the semantic info hoverer that use the same principle work fine. I'll look into that. |
I figured out the problem: It is an ordering issue. If Switching on |
Not yet ready for review