Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly inherit scriptminsize and scriptsizemultiplier #515

Merged
merged 1 commit into from
Jun 15, 2020

Conversation

dpvc
Copy link
Member

@dpvc dpvc commented Jun 11, 2020

This PR allows scriptminsize and scriptsizemultiplier to be inherited to any element, since these values are used in computing the scaling factor for any element. Currently, these attributes have no effect because they are not being inherited properly.

@dpvc dpvc added this to the v3.1.0 milestone Jun 11, 2020
@dpvc dpvc requested a review from zorkow June 11, 2020 21:14
Copy link
Member

@zorkow zorkow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

@dpvc dpvc merged commit 331cd13 into develop Jun 15, 2020
@dpvc dpvc deleted the fix-scriptsize branch June 15, 2020 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants