Improve CSS for stretchy braces in IE and Edge #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zorkow
requested changes
Feb 14, 2018
| 'margin-top': this.em(-He) | ||
| styles['.MJX-TEX mjx-stretchy-v[c="' + c + '"] > mjx-mid'] = { | ||
| 'margin-top': this.em(-Hm/2), | ||
| 'margin-bottom': this.em(-Hm/2) |
There was a problem hiding this comment.
Why can't the mid case from lines 407-411 be handled here?
Can we ever get a mid part without end part?
Or is it important that the styles is set earlier?
There was a problem hiding this comment.
Not sure why it is in the location. Probably due to doing one part at one time and the other at later time. I've moved them to the same location and tidied up a bit.
There was a problem hiding this comment.
Oh, I see why it was the way. The original CSS was for a different element, but was changed to the mid element, and I didn't catch that it could be moved earlier.
|
This is ready for re-review. |
Add initial value to reduce() calls to avoid problems with empty arrays. #74
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adjusts the CSS to avoid the gaps pointed out by Neil in #64, and improves the situation for horizontal placement of extenders in Firefox (though not for Chrome).