Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TeX] \overset not preventing movable limits #2709

Closed
pkra opened this issue Jun 15, 2021 · 2 comments
Closed

[TeX] \overset not preventing movable limits #2709

pkra opened this issue Jun 15, 2021 · 2 comments
Labels
Accepted Issue has been reproduced by MathJax team Fixed Test Needed v3 v3.2
Milestone

Comments

@pkra
Copy link
Contributor

pkra commented Jun 15, 2021

This is basically #1929, but for v3.

On mathjax.org#demo (and also with the develop branch), \( \overset{a}{\prod }\) will render the a as a superscript (which it shouldn't).

@pkra
Copy link
Contributor Author

pkra commented Jun 15, 2021

It seems like the moveable limits check in

https://github.com/mathjax/MathJax-src/blob/5650c74c4d1102e96ae081bd76c90b87c617394f/ts/input/tex/base/BaseMethods.ts#L619-L633

doesn't quite work. Replacing it with the one from underover seems to do the job.

pkra added a commit to AmerMathSoc/MathJax-src that referenced this issue Jun 15, 2021
@dpvc
Copy link
Member

dpvc commented Jun 15, 2021

Thanks for the report. It looks like the condition for \overset is not the same as for \underset or \overunderset, and they differ from the one used in the ParserUtil.underOver() method. unfortunately, your suggested solution isn't quite right, either. For one thing, you have left off the check for the movablelimits property on the node itself (which is important), and the check you are doing assumes the base is an mo element, which it may not be here.

I will push a branch that makes a utility function for making the check, and use it in all four places.

@dpvc dpvc added Accepted Issue has been reproduced by MathJax team Ready for Review Test Needed v3 labels Jun 15, 2021
dpvc added a commit to mathjax/MathJax-src that referenced this issue Jun 15, 2021
dpvc added a commit to mathjax/MathJax-src that referenced this issue Jun 15, 2021
Fix setting of movablelimits to false for \overset and similar macros.  (mathjax/MathJax#2709)
@dpvc dpvc added Merged Merged into develop branch and removed Ready for Review labels Jun 15, 2021
@dpvc dpvc added this to the 3.2 milestone Jun 16, 2021
@dpvc dpvc added Fixed v3.2 and removed Merged Merged into develop branch labels Jul 6, 2021
@dpvc dpvc closed this as completed Jul 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Accepted Issue has been reproduced by MathJax team Fixed Test Needed v3 v3.2
Projects
None yet
Development

No branches or pull requests

2 participants