Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix setting of movablelimits to false for \overset and similar macros. (mathjax/MathJax#2709) #729

Merged
merged 1 commit into from
Jun 15, 2021

Conversation

dpvc
Copy link
Member

@dpvc dpvc commented Jun 15, 2021

This PR adds a ParseUtil method for determining if a base needs to have movablelimits set to false, and then uses it in \oerset, \underset, \overundetset, and ParseUtil.underOver() (used by \overbrace and similar macros). This makes sure all these situations work the same (currently there are three different criteria being used).

Resolves issue mathjax/MathJax#2709.

@dpvc dpvc added this to the 3.2 milestone Jun 15, 2021
@dpvc dpvc requested a review from zorkow June 15, 2021 13:06
Copy link
Member

@zorkow zorkow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm. Very nice and clean!

@dpvc dpvc merged commit f0f3f76 into develop Jun 15, 2021
@dpvc dpvc deleted the issue2709 branch June 15, 2021 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants