Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for function Ctg is missing #24

Closed
FoggyFinder opened this issue Feb 19, 2017 · 6 comments
Closed

Support for function Ctg is missing #24

FoggyFinder opened this issue Feb 19, 2017 · 6 comments

Comments

@FoggyFinder
Copy link
Contributor

It seems that support for function Ctg is missing. I think it makes sense to add it. I can do it, but I would like to know which option is better:

  1. Replacing the function by tg when parsing (so, add ctg to the class Pseudo)
  2. Implement full support
@cdrnet
Copy link
Member

cdrnet commented Feb 19, 2017

I don't think I've heard about ctg and tg functions. What are these about?

@FoggyFinder
Copy link
Contributor Author

@cdrnet sorry, I meant
ctg - cotangents
tg - tangents

@cdrnet
Copy link
Member

cdrnet commented Feb 19, 2017

Ah, right. In Numerics we refer to them as tan and cot. Maybe there are different naming schemes?

Of course, I'm fine with adding them. If we add cot (or ctg), we may want to add sec and csc as well to get the full set (cot=1/tan, sec=1/cos, csc=1/sin).

@cdrnet
Copy link
Member

cdrnet commented Feb 19, 2017

So the remaining question is whether they shall be full expressions or just infix parsing magic. I'd vote to implement them fully and then maybe provide a routine later that simplifies all of them to sin and cos (on demand).

@FoggyFinder
Copy link
Contributor Author

Next week, I'll think how can expand the module Trigonometric, so I will leave the issue open

@FoggyFinder
Copy link
Contributor Author

#46

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants