Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Genscript changes #130

Merged
merged 6 commits into from
Aug 14, 2020
Merged

Genscript changes #130

merged 6 commits into from
Aug 14, 2020

Conversation

nbhoski
Copy link
Member

@nbhoski nbhoski commented Aug 7, 2020

  • Leverages genscript package to generate MATLAB runner script file dynamically.
  • Existing runMatlabTests.m file will now only contain logic to generate the script and run based on artifact parameters

mcafaro
mcafaro requested changes Aug 7, 2020
View reviewed changes
Copy link
Member

@mcafaro mcafaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SangaviJayagopi this one probably needs extra bashing because it is using features of scriptgen that haven't been used in a plugin before.

src/main/java/com/mathworks/ci/RunMatlabTestsBuilder.java Outdated Show resolved Hide resolved
@nbhoski nbhoski requested a review from mcafaro August 11, 2020 09:43
@nbhoski nbhoski requested a review from mcafaro August 12, 2020 07:28
mw-akumar
mw-akumar approved these changes Aug 12, 2020
View reviewed changes
Copy link
Member

@mw-akumar mw-akumar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great to see all the code deletion :-)

mcafaro
mcafaro approved these changes Aug 12, 2020
View reviewed changes
Copy link
Member

@mcafaro mcafaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just remove the use of SourceFolder and lets keep a discussion going around the stack trace stuff.

src/main/resources/com/mathworks/ci/RunMatlabTestsBuilder/runMatlabTests.m Outdated Show resolved Hide resolved
@nbhoski nbhoski mentioned this pull request Aug 13, 2020
Open
@nbhoski nbhoski requested a review from mcafaro August 13, 2020 15:28
@mcafaro mcafaro mentioned this pull request Aug 13, 2020
Closed
@nbhoski nbhoski merged commit 4cb26c9 into dev_main Aug 14, 2020
@nbhoski nbhoski deleted the genscript_changes branch September 3, 2020 09:47
This was referenced Sep 10, 2020
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mw-akumar mw-akumar mw-akumar approved these changes

@mcafaro mcafaro Awaiting requested review from mcafaro

Assignees

@SangaviJayagopi SangaviJayagopi

@acampbel acampbel

@abhargav-mw abhargav-mw

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@nbhoski @mcafaro @mw-akumar @SangaviJayagopi @acampbel @abhargav-mw