Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

matlab-2.1.4-Qualification #150

Merged
merged 33 commits into from
Oct 15, 2020
Merged

matlab-2.1.4-Qualification #150

merged 33 commits into from
Oct 15, 2020

Conversation

nbhoski
Copy link
Member

@nbhoski nbhoski commented Sep 10, 2020

This qual branch includes fix for .

#128 #129 #132 #134 #138

##Features

abhargav-mw and others added 30 commits August 7, 2020 12:09
@abhargav-mw
Temp path issue (#128)
d821dd2 
* Fix Java temp path discrepancy

* Fix Java temp path discrepancy

* Fix Java temp dir discrepancy

* Fix test for temp dir discrepancy

* Fix Java temp path discrepancy

* Fix Java temp dir path discrepancy

* Fix temp path issue_Incorporate reviews

* Fix temp path discrepancy_use computer channel
Scriptgen support for test run
e0ddf94
consoldiated copy operation
7220a07
@abhargav-mw
Change code coverage tool to JaCoCo (#129)
9358389
changed runner file name and changed the copy location.
dfd6dec
handdled cache issue in pom
4aef46a
Removed src folder and addpath
52049e2
Changed to addpath approach
1ed84b0
@nbhoski
Merge pull request #130 from mathworks/genscript_changes
4cb26c9 
Genscript changes
@abhargav-mw
Merge pull request #140 from mathworks/hot_fixes_issue_132
575ba75 
Hot fixes issue 132
@nbhoski
Merge pull request #141 from jenkinsci/master
a74c602 
Sync pom changes to dev_main
Support to write test runner script instead copying in worksapce.
78ac049
Added support to verify valid MATLAB path.
19ea2e7
Updated as per review
079c8ea
Updated tests
45f64b6
Updated tests
e00bdb3
Merge branch 'github_issue_138' of https://github.com/mathworks/jenki…
a9c3791 
…ns-matlab-plugin into github_issue_138
Updated tests
93dbc57
Updated copyright in new error class
669af9f
Removed experimental constructor
d919dae
Expanding the location path
229ab24
@nbhoski
Merge pull request #143 from mathworks/genscript_write_issue134
5cd5df0 
Support to write test runner script instead copying in worksapce.
setting the timeout for tests
1c8b846
Replaced runMatlabTests.m rferance in document.
268b413
Updated exe perimission
a0529c9
testing by removing some tests
8388a3e
added tests back
2f82c48
Using latest windows server on azure
b6c8f9a
Updated as per review comments
885d4e6
changed bin path logic as per review
0efb33a
This was linked to issues Sep 15, 2020
runMatlabTests.m script from older builds exists in workspace after the plugin upgrade #151
Closed
Text Input for artifacts such as: matlabTestArtifact's/taptestresults.tap causes build failure #152
Closed
SangaviJayagopi
SangaviJayagopi reviewed Sep 15, 2020
View reviewed changes
Copy link
Member

@SangaviJayagopi SangaviJayagopi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Open issues: #151 and #152

@SangaviJayagopi SangaviJayagopi linked an issue Sep 16, 2020 that may be closed by this pull request
Error/Warning messages for generating artifacts can be more specific #153
Open
@SangaviJayagopi SangaviJayagopi removed a link to an issue Sep 24, 2020
Error/Warning messages for generating artifacts can be more specific #153
Open
@SangaviJayagopi SangaviJayagopi linked an issue Sep 28, 2020 that may be closed by this pull request
For version R2017a , R2017b build fails with error using eval #154
Closed
SangaviJayagopi
SangaviJayagopi approved these changes Oct 1, 2020
View reviewed changes
Copy link
Member

@SangaviJayagopi SangaviJayagopi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#151 and #154 closed

@nbhoski
Copy link
Member Author

nbhoski commented Oct 6, 2020 •
edited
Loading

@SangaviJayagopi should #152 be closed ? You need not wait to get it published if the code is already pushed in with the fix.

@abhargav-mw
Copy link
Contributor

#152 is closed after qualification. Merging this PR

@abhargav-mw abhargav-mw merged commit e7c3f49 into master Oct 15, 2020
@nbhoski nbhoski deleted the 2.1.4-Qualification branch August 5, 2021 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SangaviJayagopi SangaviJayagopi SangaviJayagopi approved these changes

Assignees

@mcafaro mcafaro

@acampbel acampbel

@mw-akumar mw-akumar

@mw-hrastega mw-hrastega

@abhargav-mw abhargav-mw

Labels
None yet
Projects
None yet
Milestone
No milestone
7 participants
@nbhoski @abhargav-mw @SangaviJayagopi @mcafaro @acampbel @mw-akumar @mw-hrastega