-
Notifications
You must be signed in to change notification settings - Fork 491
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
consensus/bor/heimdall: add new meter and timer metrics in heimdall client #459
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #459 +/- ##
===========================================
- Coverage 56.96% 56.90% -0.06%
===========================================
Files 609 610 +1
Lines 69978 70000 +22
===========================================
- Hits 39864 39836 -28
- Misses 26718 26766 +48
- Partials 3396 3398 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
DD updates confirmed - clear to go. |
Confirmed on DD. All looks good. Link to the list of metrics for reference. We can proceed with merge. @JekaMas @temaniarpit27 |
Looks good to me! |
This PR adds new timer and meter metrics for the heimdall client for gathering relevant data. For now, it keeps track of duration of each request to heimdall and the success and failure count.
TODOs