add : TestValidatorWentOffline #507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xsharma
requested review from
temaniarpit27,
JekaMas,
0xKrishna and
manav2401
JekaMas
reviewed
Aug 31, 2022
JekaMas
reviewed
Aug 31, 2022
JekaMas
reviewed
Aug 31, 2022
Codecov ReportBase: 56.93% // Head: 56.85% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #507 +/- ##
===========================================
- Coverage 56.93% 56.85% -0.08%
===========================================
Files 610 607 -3
Lines 69999 69976 -23
===========================================
- Hits 39854 39785 -69
- Misses 26748 26788 +40
- Partials 3397 3403 +6
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
JekaMas
approved these changes
Sep 2, 2022
Raneet10
approved these changes
Sep 2, 2022
manav2401
approved these changes
Sep 2, 2022
manav2401
approved these changes
Sep 2, 2022
JekaMas
approved these changes
Sep 5, 2022
JekaMas
force-pushed
the
shiva/pos-730
branch
from
18546fe
to
a4eb03e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, we add a red test where we test a validator coming back online after a crash and reorging their backup blocks generated by the secondary validator.