MAT-170 - Wiggle for heimdall tx #87
Conversation
| @@ -85,6 +87,32 @@ func isProposer(cliCtx cliContext.CLIContext) bool { | |||
| return false | |||
| } | |||
|
|
|||
| // IsStateSyncer returns if current user is state syncer or not | |||
| func IsStateSyncer(cliCtx cliContext.CLIContext) bool { | |||
There was a problem hiding this comment.
| func IsStateSyncer(cliCtx cliContext.CLIContext) bool { | |
| func IsStateSyncer(cliCtx cliContext.CLIContext) (isStateSyncer bool) { |
| // IsStateSyncer returns if current user is state syncer or not | ||
| func IsStateSyncer(cliCtx cliContext.CLIContext) bool { | ||
| var stateSyncerList []types.Validator | ||
| isStateSyncer := false |
There was a problem hiding this comment.
We can remove this, because we are anyway implicitly returning false and true
| isStateSyncer = true | ||
| break |
There was a problem hiding this comment.
Directly return true here?
|
|
||
| // fetch state syncer list | ||
| res, err := cliCtx.QueryWithData(fmt.Sprintf("custom/%s/%s/%s", clerkTypes.QuerierRoute, clerkTypes.QueryStateSyncer), nil) | ||
|
|
| for _, record := range data.EventRecords { | ||
| keeper.SetEventRecord(ctx, *record) | ||
| } | ||
| } | ||
|
|
||
| keeper.SetStateSyncEventCount(ctx, uint64(eventCount)) |
There was a problem hiding this comment.
It might be the case where keeper.SetEventRecord(ctx, *record) will return an error but eventCount will not reflect that. Let's handle that error and/or ensure EventCount is always equal to actual events stored.
There was a problem hiding this comment.
Event Count is always equal to actual events stored.
There was a problem hiding this comment.
oh yes, it has to be, but in this case in one case it might not be. The case where SetStateSyncEventCount throws an error.
|
|
||
| // convert state sync event to bytes | ||
| eventCountInBytes := []byte(strconv.FormatUint(eventCount, 10)) | ||
|
|
| expectedValIDs []types.ValidatorID | ||
| } | ||
|
|
||
| dataItems := []TestDataItem{ |
| for i := 0; i < syncerCount; { | ||
| valIndex := eventCount % uint64(validatorCount) | ||
| validator, _ := stakingKeeper.GetValidatorFromValID(ctx, types.ValidatorID(valIndex+1)) | ||
| if stakingKeeper.IsCurrentValidatorByAddress(ctx, validator.Signer.Bytes()) { |
There was a problem hiding this comment.
Can't we get validators from current validator set instead of getting all validators and filter by validator status?
There was a problem hiding this comment.
Yeah. we can do that.
We should sort the current validator set by valID and do a binary search of validator Index.
Sorting is extra time complexity.
Considering CurrentValSet count is less, sorting should be fine i think.
There was a problem hiding this comment.
@mankenavenkatesh Validators in CurrentValSet will be already sorted as signer as far as I know. Can you check?
| var stateSyncerList []types.Validator | ||
| isStateSyncer := false | ||
|
|
||
| result, err := FetchFromAPI(cliCtx, GetHeimdallServerEndpoint(fmt.Sprintf(StateSyncerURL))) |
There was a problem hiding this comment.
What if all three validators are offline?
There was a problem hiding this comment.
That would be the case if we go with backup model also.
Ideally, Instead of 3 validators We should increase the number to 1/3rd of currentvalidatorset count. It results in more number of transactions per sync.
Let me know if there is any better idea.
There was a problem hiding this comment.
Yeah 1/3rd of current validator set would be better here and in bor as backup.
|
@mankenavenkatesh Please resolve comments |
Wiggle for heimdall tx.
Approach- https://hackmd.io/055mjdcEQUa0uzAqMPLdNg