Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong color on single keys when setting color for key group #2

Closed
amorgner opened this issue Jun 20, 2016 · 6 comments
Closed

Wrong color on single keys when setting color for key group #2

amorgner opened this issue Jun 20, 2016 · 6 comments
Labels

Comments

@amorgner
Copy link

First, thanks a lot for providing a tool for Linux support for this keyboard, greatly appreciated!

When using the -g command to set the color for a group of keys sometimes the wrong color is set on random single keys.

The more keys you set within a group the more keys will have the wrong color. The effect gets worse on a faster computer (laptop vs. fast desktop computer) and seems to increase with the number of keys set in one operation, so it might be a timing issue. Also, using the -p command to set a profile for all keys, I end up with a couple of wrong key colors.

Repeating the command helps for single groups, so after a couple of attempts, the colors are correct. However, this work doesn't help when setting a complete profile with -p.

@MatMoul
Copy link
Owner

MatMoul commented Jun 20, 2016

Hello, thank you for your return.

On my old dual core, it works but I also noticed that he had yet to be a problem.

I'll test it on my Xeon workstation as soon as possible.

Tentatively, it may be possible to modify line 575 of keyboard.cpp.
By reducing the value of maxKeyValueCount to 1 or an intermediate value.

@MatMoul MatMoul mentioned this issue Jun 20, 2016
@MatMoul MatMoul added the bug label Jun 20, 2016
@MatMoul
Copy link
Owner

MatMoul commented Aug 7, 2016

Encounter the same problem on my old PC with the last kernel, I set maxKeyValueCount to 1 pending a better solution.

@amorgner
Copy link
Author

Setting maxKeyValueCount to 1 doesn't help here. I've also tried changing other settings and modifying the code but no luck. I think the general problem persists.

@MatMoul
Copy link
Owner

MatMoul commented Aug 16, 2016

Ok, I just pushed a new version, if problem persist, look at ticket #4.

@amorgner
Copy link
Author

That seems to fix it, no issues so far. Thanks a lot!

@jegade
Copy link

jegade commented Aug 16, 2016

Thank you, now it is fix here too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants