check if a2enconf exists in the postinst script #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Fixes #68 |
|
Makes sense to me (on my server and notebook without apache @aureq will need to take a closer look, but it should be fine to merge. |
aureq
approved these changes
Nov 18, 2018
|
Thank you for the patch @mackuba |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have a
/etc/apache2/conf-availabledirectory on my server, because it was created by default during the installation, but I have uninstalled the apache package itself, because I'm using Nginx as my web server. Thepostinstscript however checks for the existence of that config directory and then assumes that Apache is installed and tries to run thea2enconftool, which is not available on that machine.So I've added a check to make sure that
/usr/sbin/a2enconfactually exists and is executable before calling it.