Merge pull request #13783 from anntzer/remotedata

Deprecate disable_internet.
matplotlib · Jul 27, 2019 · 8d3e817 · 8d3e817
2 parents 6376425 + d9dc9d0
commit 8d3e817
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 9 deletions.
diff --git a/doc/api/next_api_changes/2019-03-29-AL.rst b/doc/api/next_api_changes/2019-03-29-AL.rst
@@ -0,0 +1,7 @@
+Deprecations
+````````````
+
+The ``matplotlib.testing.disable_internet`` module is deprecated.  Use (for
+example) pytest-remotedata_ instead.
+
+.. _pytest-remotedata: https://pypi.org/project/pytest-remotedata/
diff --git a/doc/api/testing_api.rst b/doc/api/testing_api.rst
@@ -30,15 +30,6 @@
    :show-inheritance:
 
 
-:mod:`matplotlib.testing.disable_internet`
-==========================================
-
-.. automodule:: matplotlib.testing.disable_internet
-   :members:
-   :undoc-members:
-   :show-inheritance:
-
-
 :mod:`matplotlib.testing.exceptions`
 ====================================
 

diff --git a/lib/matplotlib/testing/disable_internet.py b/lib/matplotlib/testing/disable_internet.py
@@ -4,6 +4,10 @@
 import contextlib
 import socket
 
+from matplotlib import cbook
+cbook.warn_deprecated("3.2", name=__name__, obj_type="module",
+                      alternative="pytest-remotedata")
+
 # save original socket method for restoration
 # These are global so that re-calling the turn_off_internet function doesn't
 # overwrite them again