Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix variable naming in axes.quiver #1481

Closed
dmcdougall opened this issue Nov 11, 2012 · 7 comments
Closed

Fix variable naming in axes.quiver #1481

dmcdougall opened this issue Nov 11, 2012 · 7 comments
Milestone

Comments

@dmcdougall
Copy link
Member

See https://github.com/matplotlib/matplotlib/blob/master/lib/matplotlib/quiver.py#L617.

@WeatherGod
Copy link
Member

I am milestoning this for v1.3. We really can't leave this code as confusing as it is for too much longer.

@mdboom
Copy link
Member

mdboom commented May 21, 2013

What's the status on this one? I'm happy to take a crack at it, but I can't find any previous discussion about what (specifically) should be done here.

@WeatherGod
Copy link
Member

We just need to have more sensible variable names. At the very least, it
needs to have better comments by whoever understands exactly what happens
here. I especially don't like having a variable "x" and "X". Drives me
bonkers.

@mdboom
Copy link
Member

mdboom commented May 28, 2013

I'm punting this to 1.4.x, since I don't think there's time to get it in to the release candidate today.

@tacaswell
Copy link
Member

The line link no longer makes sense. @dmcdougall Can you update where the confusing code is?

Experimentally, we can leave code that confusing for quite some time.

@pelson
Copy link
Member

pelson commented Jan 20, 2014

Experimentally, we can leave code that confusing for quite some time.

😄 evidently

@tacaswell
Copy link
Member

Closing this as it in 2+ years old.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants