New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
strange output from wx and wxagg when trying to render to JPEG or TIFF #1770
Conversation
What's happening here is that for JPEG, TIF, etc., it's using the Wx, not the WxAgg backend for rendering (with all of the bugs associated with that backend). I think the true fix for this is to add a |
Ah, I see. I didn't see the WxAgg specific print_png code...I'll look over things again and try to implement the fix that you recommend above. |
Looks like this PR is superceeded by #1771. Is that correct? If so, please feel free to close. |
No, it's not. It's a separate issue. |
And I'm not sure that I am going to have a chance to sit down and figure out how to fix this as mdboom recommends...is there a way to formally express this pull request as an issue? |
I'm milestoning it as 1.3.x so we don't lose track of the underlying issue. If you or someone else (perhaps myself) submits an alternative PR, we can close this in favor of it then. |
This (on quick inspection) looks to be the same as issue #1877 |
I agree tacaswell. |
If PIL is present, the wx backend needs to allow the base class to get the job done for print_jpeg and print_tiff, instead of trying to take over duties itself.
strange output from wx and wxagg when trying to render to JPEG or TIFF
This patch has been tested under Windows, OSX, and Linux. If PIL is present, it gives an accurate rendering of the graph, whereas the wx backend's print_jpeg and print_tiff don't. I've attached before and after pictures (before and after this patch).
Other backends that might exhibit similar behavior, but I am not in a position to test, are:
A test script that generates the images is below.
Before, png
Before,jpeg
Before, tif
[Could not display because file type unsupported...it looked very similar to the "before" jpeg]
After, png
After, jpeg
After,tif
[Could not display because file type unsupported...it looked very similar to the "after" jpeg]