Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PEP8 conformance test fails without listing location of failures #2091

Closed
mdboom opened this issue May 29, 2013 · 6 comments
Closed

PEP8 conformance test fails without listing location of failures #2091

mdboom opened this issue May 29, 2013 · 6 comments

Comments

@mdboom
Copy link
Member

mdboom commented May 29, 2013

We are currently seeing this on master:

======================================================================
FAIL: matplotlib.tests.test_coding_standards.test_pep8_conformance
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/travis/virtualenv/python2.6/lib/python2.6/site-packages/nose/case.py", line 197, in runTest
    self.test(*self.arg)
  File "/home/travis/virtualenv/python2.6/lib/python2.6/site-packages/matplotlib-1.3.0rc2-py2.6-linux-x86_64.egg/matplotlib/tests/test_coding_standards.py", line 217, in test_pep8_conformance
    assert_equal(result.total_errors, 0, "Found code syntax "
AssertionError: Found code syntax errors (and warnings).
----------------------------------------------------------------------

Cc: @pelson

@pelson
Copy link
Member

pelson commented May 30, 2013

Yeah, this should definitely be improved. It is worth noting that the warnings which enumerate the exceptions are peppered inline with the test output, so it is there - just not very convenient...

@pelson
Copy link
Member

pelson commented May 30, 2013

I can't see the failing test on travis. Which build was it? (https://travis-ci.org/matplotlib/matplotlib/builds)

@mdboom
Copy link
Member Author

mdboom commented May 30, 2013

@pelson
Copy link
Member

pelson commented May 30, 2013

The problems look like:

/home/travis/virtualenv/python2.6/lib/python2.6/site-packages/matplotlib-1.3.0rc2-py2.6-linux-x86_64.egg/matplotlib/textpath.py:66:30: E231 missing whitespace after ','
/home/travis/virtualenv/python2.6/lib/python2.6/site-packages/matplotlib-1.3.0rc2-py2.6-linux-x86_64.egg/matplotlib/textpath.py:66:32: E231 missing whitespace after ','
/home/travis/virtualenv/python2.6/lib/python2.6/site-packages/matplotlib-1.3.0rc2-py2.6-linux-x86_64.egg/matplotlib/textpath.py:66:34: E231 missing whitespace after ','
/home/travis/virtualenv/python2.6/lib/python2.6/site-packages/matplotlib-1.3.0rc2-py2.6-linux-x86_64.egg/matplotlib/textpath.py:68:30: E231 missing whitespace after ','
/home/travis/virtualenv/python2.6/lib/python2.6/site-packages/matplotlib-1.3.0rc2-py2.6-linux-x86_64.egg/matplotlib/textpath.py:68:32: E231 missing whitespace after ','
/home/travis/virtualenv/python2.6/lib/python2.6/site-packages/matplotlib-1.3.0rc2-py2.6-linux-x86_64.egg/matplotlib/textpath.py:68:39: E231 missing whitespace after ','
/home/travis/virtualenv/python2.6/lib/python2.6/site-packages/matplotlib-1.3.0rc2-py2.6-linux-x86_64.egg/matplotlib/textpath.py:69:43: E231 missing whitespace after ','

@mdboom
Copy link
Member Author

mdboom commented May 30, 2013

Ok. I've just gone ahead and disabled this test in 3a3f28c for now. I think if we're going to do this as a full on failure, the messages need to be prominent and easy to find. Once we've resolved this, we can re-enable this.

@tacaswell
Copy link
Member

I am closing this as the errors look useful to me now and it looks like #2099 fixed this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants