Fix bugs related to bottom kwarg in step histograms #2297
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is targeting master. #1724 targets |
|
Argh, you're right. I'll rebase it when I get a chance. |
|
Closed in favor of #2409 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This completes the fix to #1763. #1724 partially fixed this, but I just discovered it only solved the problem for the
barhisttype. This PR fixes it for thestephisttype also.I also discovered another small bug while I was doing this, which I fixed. There was some code that should have only been executed for stacked histograms, but was being run for all histograms. My fix doesn't result in any visible change, as the problem was hidden by lines drawing over the top of each other.