Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests.py is missing from pypi tarball #5831

Closed
jlec opened this issue Jan 11, 2016 · 5 comments
Closed

tests.py is missing from pypi tarball #5831

jlec opened this issue Jan 11, 2016 · 5 comments
Assignees
Milestone

Comments

@jlec
Copy link

jlec commented Jan 11, 2016

Please include tests.py so that downstream maintainers can properly test.

@tacaswell tacaswell added this to the next major release (2.0) milestone Jan 11, 2016
@tacaswell
Copy link
Member

Have we ever included tests.py in the pypi tarball?

I suggest pulling the src tarball from gh instead?

@jenshnielsen
Copy link
Member

I suspected that it might have been removed in #4668 but that does not seem to be the case.

@jlec
Copy link
Author

jlec commented Jan 11, 2016

Many downstream distro like fedora, debian, gentoo and so are using the pypi tarball, as this is what you are intending to ship to the end user. Therefor I rather dislike the idea to fetch directly from GH. Shouldn't be a big deal to include that file. Currently we are running ${PYTHON} -c "import sys, matplotlib as m; sys.exit(0 if m.test(verbosity=2) else 1)" but I really want to run the tests in the same way as you are doing it.

@tacaswell
Copy link
Member

Fair enough. I am biased towards pulling directly from the tag on gh as it
is the ground truth, but I will not argue with packagers about packaging. (
I was just trying to be helpful and suggest work arounds for right now).

Unless this is a regression I don't think this is enough to force a new
release, but will be fixed in the next one.

On Mon, Jan 11, 2016, 07:56 Justin Lecher notifications@github.com wrote:

Many downstream distro like fedora, debian, gentoo and so are using the
pypi tarball, as this is what you are intending to ship to the end user.
Therefor I rather dislike the idea to fetch directly from GH. Shouldn't be
a big deal to include that file. Currently we are running ${PYTHON} -c
"import sys, matplotlib as m; sys.exit(0 if m.test(verbosity=2) else 1)"
but I really want to run the tests in the same way as you are doing it.


Reply to this email directly or view it on GitHub
#5831 (comment)
.

@jlec
Copy link
Author

jlec commented Jan 11, 2016

Unless this is a regression I don't think this is enough to force a new release, but will be fixed in the next one.

no, that can be done in the next release. thanks.

@tacaswell tacaswell modified the milestones: Critical bug fix release (1.5.2), next major release (2.0) Jan 12, 2016
@tacaswell tacaswell self-assigned this Jan 12, 2016
tacaswell added a commit to tacaswell/matplotlib that referenced this issue May 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants