Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: LogLocator.set_params is broken #7043

Closed
efiring opened this issue Sep 5, 2016 · 1 comment
Closed

BUG: LogLocator.set_params is broken #7043

efiring opened this issue Sep 5, 2016 · 1 comment
Assignees
@efiring
Labels
Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions.
Milestone
v2.0.0

Comments

@efiring
Copy link
Member

efiring commented Sep 5, 2016

In master, set_params is clobbering two methods, base and subs. Probably they should be properties. LogLocator could use other cleanups as well.
@efiring efiring added this to the 2.0 (style change major release) milestone Sep 5, 2016
@efiring efiring added the Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions. label Sep 5, 2016
This was referenced Sep 5, 2016
Closed
Merged
@efiring efiring self-assigned this Sep 5, 2016
@efiring
Copy link
Member Author

efiring commented Sep 11, 2016

Closed by #7045.

@efiring efiring closed this as completed Sep 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@efiring efiring

Labels
Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions.
Projects
None yet
Milestone
v2.0.0
Development

No branches or pull requests
1 participant
@efiring