Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Long lines in literal blocks run off the edge of the page #8153

Closed
dstansby opened this issue Feb 26, 2017 · 6 comments
Closed

Long lines in literal blocks run off the edge of the page #8153

dstansby opened this issue Feb 26, 2017 · 6 comments
Milestone

Comments

@dstansby
Copy link
Member

e.g.
screen shot 2017-02-25 at 12 44 54

I assume the fix is to make the box scrollable, which would probably be an upstream fix.

@tacaswell tacaswell modified the milestones: 2.0.1 (next bug fix release), 2.1 (next point release) Feb 26, 2017
@tacaswell
Copy link
Member

might also be in the templates..

@NelleV
Copy link
Member

NelleV commented Mar 19, 2017

I don't think the appropriate fix is to add a scrollbar: this line should never have been that long in the first place.

@anntzer
Copy link
Contributor

anntzer commented Mar 19, 2017

Why not? This is the output of git lg as defined in the docs.

@NelleV
Copy link
Member

NelleV commented Mar 19, 2017

The subject line of a git commit should be less than 50 caracters, while the body should be wrapped into 72 caracters line.

Even if you don't consider this, scrollbars are terrible UI designs.

@NelleV
Copy link
Member

NelleV commented Mar 19, 2017

(I find the guidelines on writing git commit messages very stringent, and often don't follow them myself, but there is a difference between writing 80 caraters line, and a full paragraph in the title. These are bad practices, and we should not advertise them in our documentation.)

@anntzer
Copy link
Contributor

anntzer commented Mar 19, 2017

The output of git lg can still overrun the limit (due to the SHA1 and branch name being prepended), but I agree with you that this specific piece is a bad example.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants