Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor update to multiprocessing example. #10168

Merged
merged 1 commit into from
Jan 19, 2018
Merged

Minor update to multiprocessing example. #10168

merged 1 commit into from
Jan 19, 2018

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Jan 5, 2018

PR Summary

Pick up the parts of #6637 that have not yet been covered by #9900.

PR Checklist

  • Has Pytest style unit tests
  • Code is PEP 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@anntzer anntzer mentioned this pull request Jan 5, 2018
Closed
@tacaswell tacaswell added this to the v2.2 milestone Jan 7, 2018
QuLogic
QuLogic reviewed Jan 9, 2018
View reviewed changes
examples/misc/multiprocess_sgskip.py
@@ -43,30 +49,26 @@ def __init__(self):
def terminate(self):
plt.close('all')

def poll_draw(self):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh, what was the point of this? Some kind of closure effect?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure, but AFAICT it works without it...

QuLogic
QuLogic approved these changes Jan 9, 2018
View reviewed changes
Copy link
Member

@QuLogic QuLogic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me, at least.

@anntzer anntzer mentioned this pull request Jan 11, 2018
Closed
@jklymak jklymak merged commit 0d3beeb into matplotlib:master Jan 19, 2018
@anntzer anntzer deleted the update-multiprocessing-example branch January 19, 2018 22:44
@QuLogic QuLogic modified the milestones: needs sorting, v2.2.0 Feb 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QuLogic QuLogic QuLogic approved these changes

Assignees
No one assigned
Labels
Documentation
Projects
None yet
Milestone
v2.2.0
Development

Successfully merging this pull request may close these issues.
4 participants
@anntzer @QuLogic @tacaswell @jklymak