Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST: Small fix to constrainedlayout7 test (removed image) #10387

Merged

Conversation

jklymak
Copy link
Member

@jklymak jklymak commented Feb 6, 2018

PR Summary

@QuLogic noted that the tests were emitting errors due to #9082. Was written before I understood pytest as well as I do now (which is almost zero, but was really zero before). Now I catch the warning rather than letting it emit and make the warning the test. This drops an image.

@jklymak jklymak added topic: geometry manager LayoutEngine, Constrained layout, Tight layout topic: testing labels Feb 6, 2018
@jklymak jklymak added this to the v2.2 milestone Feb 6, 2018
@jklymak
Copy link
Member Author

jklymak commented Feb 6, 2018

xref #10385

@dstansby dstansby merged commit bf2127b into matplotlib:master Feb 6, 2018
@QuLogic QuLogic modified the milestones: needs sorting, v2.2.0 Feb 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: geometry manager LayoutEngine, Constrained layout, Tight layout topic: testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants