Avoid UnboundLocalError in drag_pan. #10492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Axes.drag_pan should probably have been private but it's public and should therefore properly handle unexpected input.
dstansby
approved these changes
Feb 16, 2018
WeatherGod
approved these changes
Feb 16, 2018
| @@ -4014,7 +4014,7 @@ def format_deltas(key, dx, dy): | |||
| p = self._pan_start | |||
| dx = x - p.x | |||
| dy = y - p.y | |||
| if dx == 0 and dy == 0: | |||
| if dx == dy == 0: | |||
There was a problem hiding this comment.
Oh, cool. I didn't realize you could do that with equals. I just always thought it was a special case in the interpreter for the < and > to do "between" tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Axes.drag_pan should probably have been private but it's public and
should therefore properly handle unexpected input, as exposed in #9772.
PR Summary
PR Checklist