Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Postscript allow empty markers #10935

Merged
merged 1 commit into from
Apr 1, 2018

Conversation

jklymak
Copy link
Member

@jklymak jklymak commented Apr 1, 2018

PR Summary

If you set a marker to have markerfacecolor='none' with the eps backend, no marker is drawn, even if the edgecolor is non-zero. Thats silly. This checks and if none, just doesn't issue the fill command instead of returning before anything is drawn...

I couldn't figure out how to make a postscript test. The saved image is in pdf, but the test spits out an eps, so...

Closes #10921

PR Checklist

  • Has Pytest style unit tests
  • Code is PEP 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@jklymak jklymak added this to the v3.0 milestone Apr 1, 2018
Copy link
Member

@dstansby dstansby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reckon this should go into 2.x since it's a bugfix

@dstansby dstansby modified the milestones: v3.0, v2.2.3 Apr 1, 2018
@jkseppan jkseppan merged commit 7b5deb3 into matplotlib:master Apr 1, 2018
@jklymak
Copy link
Member Author

jklymak commented Apr 1, 2018

Hmmm did we really want to backport this? I dont mind but I think we were only backportibg regressions and crashes.

@jkseppan
Copy link
Member

jkseppan commented Apr 1, 2018

The documentation says "Everything else (regressions against 1.x versions, bugs/api inconsistencies the user can work around in their code) are on a case-by-case basis, should be low-risk, and need someone to advocate for and shepherd through the backport." I think this one is low-risk and I read @dstansby's comment as being willing to do the shepherding.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No markers in EPS if fillstyle='none'
3 participants