Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip pillow animation test if pillow not importable #10971

Merged
merged 1 commit into from
Apr 6, 2018

Conversation

dstansby
Copy link
Member

@dstansby dstansby commented Apr 6, 2018

xref #10966 - this will skip the pillow test if PIL isn't importable. I've milestoned this to v2.2-doc, as that's where the builds seem to be failing.

@dstansby dstansby added this to the v2.2-doc milestone Apr 6, 2018
Copy link
Member

@jklymak jklymak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM error looks spurious

@tacaswell tacaswell modified the milestones: v2.2-doc, v2.2.3 Apr 6, 2018
@tacaswell tacaswell merged commit ad53f46 into matplotlib:master Apr 6, 2018
@tacaswell
Copy link
Member

re-milestoned to 2.2.3, the -doc branch should get changes to things in the doc folder only.

@QuLogic
Copy link
Member

QuLogic commented Jun 22, 2018

All the doc-branch builds are hitting the macOS pillow error, which I think this fixes, so we should probably reconsider backporting it.

QuLogic pushed a commit to QuLogic/matplotlib that referenced this pull request Jun 22, 2018
Skip pillow animation test if pillow not importable
@QuLogic
Copy link
Member

QuLogic commented Jun 22, 2018

Oops, this is broken on v2.2.x too, so I guess this can't have fixed it.

@QuLogic QuLogic modified the milestones: v2.2.3, v3.0 Jul 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants