Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix pkg-config handling to make cross-compiling work #11218

Closed
wants to merge 2 commits into from
Closed

fix pkg-config handling to make cross-compiling work #11218

wants to merge 2 commits into from

Commits on May 29, 2018

  1. setupext: do not mess with PKG_CONFIG_PATH 

    The current code always sets PKG_CONFIG_PATH to build paths in / which
breaks cross-compiling -- things like /usr/lib are for the build system
(e.g. x86) and not for the target (e.g. arm).  Since we're adding paths
that are already the default for pkg-config, there's no point in trying
to be smart here.  Just punt the code.

This basically reverts commit 101beb9.
    @vapier
    vapier committed May 29, 2018
    Configuration menu
    Copy the full SHA
    5836c98 View commit details
    Browse the repository at this point in the history

  2. setupext: do not hardcode system -I/-L paths when pkg-config is avail… 

    …able

If we have pkg-config, then there's no need to hardcode the system -I/-L
paths as the pkg-config files will give us all the info we need.
    @vapier
    vapier committed May 29, 2018
    Configuration menu
    Copy the full SHA
    cd06e1b View commit details
    Browse the repository at this point in the history