tight_bbox made assumptions about the display-units without checking the figure #1138
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tries to fix #1135. Tight_bbox tries to determine the bounding box of figure contents and saves a new figure that is shrunk to the new size. When saving a PDF using the PGF backend (which internally uses display-units) the scaling is wrong.
For rescaling the figure,
adjust_bbox_pdf
does some strange unit conversions I do not understand whileadjust_bbox_png
just uses the scaling matrix from the figure. Usingfig.dpi_scale_trans
works just fine for the PGF, PDF, SVG and EPS backend, so I removed theadjust_bbox_pdf
function altogether.There are no tests for bbox_inches and I don't really understand what bbox_inches is doing, so this needs some review.