Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove embedding_in_tk_canvas, which demonstrated a private API. #11514

Merged
merged 1 commit into from
Jun 26, 2018

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Jun 26, 2018

PR Summary

See discussion in #11507.

PR Checklist

  • Has Pytest style unit tests
  • Code is PEP 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@anntzer anntzer added Documentation Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions. labels Jun 26, 2018
@anntzer anntzer added this to the v3.0 milestone Jun 26, 2018
Copy link
Member

@dstansby dstansby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 anyone feel free to merge if/when all the builds pass

@WeatherGod
Copy link
Member

We should fix the example. It is meant to show how to embed a canvas into a tk app, The blitting part is actually not really needed, we can do something else instead.

@anntzer
Copy link
Contributor Author

anntzer commented Jun 26, 2018

Is https://matplotlib.org/gallery/user_interfaces/embedding_in_tk_sgskip.html#sphx-glr-gallery-user-interfaces-embedding-in-tk-sgskip-py not good enough for you? This (currently being removed) example is a lower-level API but it's not clear getting a public API for that is really helpful (it still requires instantiating a FigureCanvasAgg (duh) so you may as well instantiate a FigureCanvasTkAgg instead and fetch the underlying tk widget with get_tk_canvas() (which is exactly what the other example does)).

@WeatherGod
Copy link
Member

Ah, you are right. I read the example too quickly. Carry on.

@WeatherGod WeatherGod merged commit fae6a33 into matplotlib:master Jun 26, 2018
@anntzer anntzer deleted the removeprivateexample branch June 26, 2018 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants