Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deprecation messages. #11643

Merged
merged 1 commit into from
Jul 12, 2018
Merged

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Jul 12, 2018

  1. in generate_deprecation message, pass addendum to the format dict
    (otherwise formatting %(addendum)s will throw).
  2. in warn_deprecated in the rcParams, key is the name of the
    deprecated object, not the whole deprecation message.

release critical per point 1).

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is PEP 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

1) in generate_deprecation message, pass `addendum` to the format dict
   (otherwise formatting `%(addendum)s` will throw).
2) in warn_deprecated in the rcParams, `key` is the name of the
   deprecated object, not the whole deprecation message.
@anntzer anntzer added the Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions. label Jul 12, 2018
@anntzer anntzer added this to the v3.0 milestone Jul 12, 2018
@dstansby
Copy link
Member

@anntzer can you reboot the circle 36 job? It's on your account so I can't do it myself.

@jklymak
Copy link
Member

jklymak commented Jul 12, 2018

Circle is just having issues - I think we can go ahead and merge non-documentation PRs if every thing else passes...

@jklymak jklymak merged commit b52a284 into matplotlib:master Jul 12, 2018
@anntzer anntzer deleted the deprecationmessages branch July 12, 2018 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants