Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix AttributeError in GTK3Agg backend #12016

Merged
merged 1 commit into from
Sep 5, 2018
Merged

Fix AttributeError in GTK3Agg backend #12016

merged 1 commit into from
Sep 5, 2018

Conversation

akhilman
Copy link
Contributor

@akhilman akhilman commented Sep 5, 2018

Fixes #12015

PR Summary

backend_cairo has not _unmultipled_rgba8888_to_premultiplied_argb32 attribute, but cbook does.
Examples doesn't work without this patch, but works well with it.

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

timhoffm
timhoffm approved these changes Sep 5, 2018
View reviewed changes
Copy link
Member

@timhoffm timhoffm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, and congratulation to your first contribution to matplotlib!

@timhoffm
Copy link
Member

timhoffm commented Sep 5, 2018

Regression from #11845.

@timhoffm timhoffm added this to the v3.0 milestone Sep 5, 2018
@timhoffm timhoffm added the Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions. label Sep 5, 2018
@timhoffm timhoffm merged commit 248399e into matplotlib:master Sep 5, 2018
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Sep 5, 2018
@timhoffm
Backport PR matplotlib#12016: Fix AttributeError in GTK3Agg backend
b7aa194
@meeseeksmachine meeseeksmachine mentioned this pull request Sep 5, 2018
Merged
@anntzer
Copy link
Contributor

anntzer commented Sep 5, 2018 •
edited
Loading

Now the real question is why flake8 didn't catch this...
I guess it doesn't check for names defined in other modules?

@anntzer anntzer mentioned this pull request Sep 5, 2018
Merged
6 tasks
dstansby added a commit that referenced this pull request Sep 5, 2018
@dstansby
Merge pull request #12017 from meeseeksmachine/auto-backport-of-pr-12…
56ee1b2 
…016-on-v3.0.x

Backport PR #12016 on branch v3.0.x (Fix AttributeError in GTK3Agg backend)
@akhilman akhilman deleted the fix-gtk3agg-attribute-error branch September 5, 2018 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QuLogic QuLogic QuLogic approved these changes

@timhoffm timhoffm timhoffm approved these changes

Assignees
No one assigned
Labels
Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions.
Projects
None yet
Milestone
v3.0.0
Development

Successfully merging this pull request may close these issues.

AttributeError with GTK3Agg backend
4 participants
@akhilman @timhoffm @anntzer @QuLogic