TST: mark test_constrainedlayout.py::test_colorbar_location as flaky #12683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anntzer
reviewed
Oct 31, 2018
jklymak
force-pushed
the
tst_mark_colorbartest_flaky
branch
from
a0c6e24
to
674e42a
Compare
jklymak
force-pushed
the
tst_mark_colorbartest_flaky
branch
from
674e42a
to
504b29a
Compare
tacaswell
approved these changes
Oct 31, 2018
timhoffm
approved these changes
Oct 31, 2018
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Oct 31, 2018
…st_colorbar_location as flaky
QuLogic
added a commit
that referenced
this pull request
Nov 1, 2018
…683-on-v3.0.x Backport PR #12683 on branch v3.0.x (TST: mark test_constrainedlayout.py::test_colorbar_location as flaky)
thoo
added a commit
to thoo/matplotlib
that referenced
this pull request
Nov 3, 2018
* 'master' of https://github.com/matplotlib/matplotlib: (50 commits) Set up CI with Azure Pipelines (matplotlib#12617) Added comment for test. Correctly remove nans when drawing paths with pycairo. Improve docs on Axes limits and direction Extend sphinx Makefile to cleanup completely Remove explicit figure number Update contributing.rst Update contributing.rst DOC: Add badge and link to making PR tutorial Added test cases for scatter plot: 1) empty data/color, 2) pandas.Series with non-0 starting index. TST: mark test_constrainedlayout.py::test_colorbar_location as flaky (matplotlib#12683) Remove deprecation warnings in tests (matplotlib#12686) Make ticks in demo_axes_rgb.py visible Change ipython block to code-block Improve linestyles example (matplotlib#12586) document-textpath Fix index out of bound error for testing first element of iterable. TST: test that get_ticks works FIX: fix error in colorbar.get_ticks not having valid data Replaced warnings.warn with either logging.warnings or cbook._warn_external ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Closes #12433
test_constrainedlayout.py::test_colorbar_locationis sometimes flaky; i.e. the constraint solver sometimes seems tochoose the wrong constraint. The flakiness is rare, but occasionally causes CI to not pass.Also added a
@pytest.mark.timeout(30)because I saw one instance where the CI timed out because of this test. I don't see that we do this elsewhere in the CI suite, so please feel free to tell me if this is incorrect.PR Checklist