Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix failure to import matplotlib.animation on Windows. #13787

Merged
merged 1 commit into from
Mar 29, 2019
Merged

Fix failure to import matplotlib.animation on Windows. #13787

merged 1 commit into from
Mar 29, 2019

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Mar 28, 2019

Path objects can't be passed to subprocess.Popen on Windows.

closes #13786.

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@anntzer
Fix failure to import matplotlib.animation on Windows.
3fcb40e 
Path objects can't be passed to subprocess.Popen on Windows.
@anntzer anntzer added Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions. topic: animation labels Mar 28, 2019
@anntzer anntzer added this to the v3.1.0 milestone Mar 28, 2019
tacaswell
tacaswell approved these changes Mar 29, 2019
View reviewed changes
Copy link
Member

@tacaswell tacaswell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test failure looks like either installation issues or more API changes in sphinx....

@dstansby dstansby merged commit 7e9c756 into matplotlib:master Mar 29, 2019
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Mar 29, 2019
@dstansby
Backport PR matplotlib#13787: Fix failure to import matplotlib.animat…
864f044 
…ion on Windows.
@meeseeksmachine meeseeksmachine mentioned this pull request Mar 29, 2019
Merged
@anntzer anntzer deleted the animwin branch March 29, 2019 10:52
dstansby added a commit that referenced this pull request Mar 29, 2019
@dstansby
Merge pull request #13791 from meeseeksmachine/auto-backport-of-pr-13…
50523e2 
…787-on-v3.1.x

Backport PR #13787 on branch v3.1.x (Fix failure to import matplotlib.animation on Windows.)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tacaswell tacaswell tacaswell approved these changes

@dstansby dstansby dstansby approved these changes

Assignees
No one assigned
Labels
Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions. topic: animation
Projects
None yet
Milestone
v3.1.0
Development

Successfully merging this pull request may close these issues.

Cannot import matplotlib.animation
3 participants
@anntzer @tacaswell @dstansby