Make normalize_kwargs more convenient for third-party use. #13978
Conversation
... by making it internally fetch the artist's private _alias_map attribute.
| # deal with default value of alias_mapping | ||
| if alias_mapping is None: | ||
| alias_mapping = dict() | ||
| elif (isinstance(alias_mapping, type) and issubclass(alias_mapping, Artist) |
There was a problem hiding this comment.
Why do you require subclasses of Artist? Wouldn't it be enough to use ducktyping via getattr(alias_mapping, "_alias_map", {}) alone?
There was a problem hiding this comment.
I would rather not duck-type on a private attribute. For example, it would seem a bit silly for the doc to say that the argument can be anything that has an _alias_map attribute. If the docs does say "mapping or Artist subclass or Artist instance", then we may as well make the implementation match that.
There was a problem hiding this comment.
I don‘t see a problem with duck-typing on a private attribute if it‘s documented. That would be the low-overhead variant of a KeywordShortcutsMixin. It would allow to use it for other stuff than Artists.
However, we can always revisit later and lift that restriction.
... by making it internally fetch the artist's private _alias_map
attribute.
See https://gitter.im/matplotlib/matplotlib?at=5cb748f2375bac7470bd5a8d.
PR Summary
PR Checklist