-
-
Notifications
You must be signed in to change notification settings - Fork 7.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TST: be more explicit about identifying qt4/qt5 imports #14139
Conversation
force-pushed to fix indentation problem. |
This is definitely helpful, though I can't quite figure out how to run one or the other. There doesn't seem to be a way in pytest to select a test based on a marker argument. And setting Do you think we should add a secondary marker for backends as well? |
|
Unfortunately, that only works if the tests are parameterized (and thus have a backend name in the test name). There are additional Qt5-specific tests that weren't run in your example (which you can see from selected vs deselected counts). |
I think, explicit backend selection for the tests is a different topic. But will leave open for now in case somebody feels the need to address it in this PR. Anybody can merge, if there's no further change wanted on the PR. |
… qt4/qt5 imports
…139-on-v3.1.x Backport PR #14139 on branch v3.1.x (TST: be more explicit about identifying qt4/qt5 imports)
closes #14137
It is a bit heavy-handed, but seems better than relying on possibly varying import time collisions from upstreams.