Minor cleanup of acorr/xcoor docs #14197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timhoffm
commented
May 12, 2019
| @@ -18,10 +18,24 @@ | |||
| fig, [ax1, ax2] = plt.subplots(2, 1, sharex=True) | |||
| ax1.xcorr(x, y, usevlines=True, maxlags=50, normed=True, lw=2) | |||
| ax1.grid(True) | |||
| ax1.axhline(0, color='black', lw=2) | |||
There was a problem hiding this comment.
Note: xcorr(usevlines=True) does already produce a horizontal line. So this is redundant.
dstansby
approved these changes
May 12, 2019
anntzer
reviewed
May 13, 2019
lib/matplotlib/axes/_axes.py
Outdated
| using `Axes.vlines`. Additionally, a horizontal line is plotted | ||
| at y=0 using `Axes.axhline`. | ||
|
|
||
| If ``False``, makers are plotted at the xcorr values using |
anntzer
approved these changes
May 13, 2019
|
I pushed a fix for the typo(s)... |
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
May 13, 2019
tacaswell
added a commit
that referenced
this pull request
May 13, 2019
…197-on-v3.1.x Backport PR #14197 on branch v3.1.x (Minor cleanup of acorr/xcoor docs)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.