Use stdlib mimetypes instead of hardcoding them. #14218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The stdlib provides all necessary mimetypes (see _default_mime_types), except for application/emf -- but we don't have an emf backend anymore. This also makes the dict (relatively) easily extensible by the end user, who could call `mimetypes.init(...)` themselves to add entries to the mapping.
tacaswell
approved these changes
May 14, 2019
QuLogic
reviewed
May 14, 2019
| self.set_header('Content-Type', mimetypes.get(fmt, 'binary')) | ||
|
|
||
| self.set_header( | ||
| 'Content-Type', mimetypes.types_map.get(fmt, 'binary')) |
There was a problem hiding this comment.
The fallback should be application/octet-stream, should it not?
There was a problem hiding this comment.
This PR leaves the old behavior, but I'd say that octet-stream is more correct, indeed.
timhoffm
approved these changes
May 14, 2019
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The stdlib provides all necessary mimetypes (see _default_mime_types),
except for application/emf -- but we don't have an emf backend anymore.
This also makes the dict (relatively) easily extensible by the end user,
who could call
mimetypes.init(...)themselves to add entries to themapping.
PR Summary
PR Checklist