Fix inversion of 3d axis. #14579
Merged
Fix inversion of 3d axis. #14579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anntzer
added
topic: mplot3d
Release critical
... which was broken because 3d axises stored and accessed their viewlim info sometimes in xy_viewLim/zz_viewLim and sometimes in v_interval (and likewise for datalim), leading to out-of-sync info... Not deprecating d_interval/v_interval for now both because this needs to go to 3.1.1 to fix the breakage and because I think storing the info in axis attributes actually makes *more* sense than in viewLim/dataLim -- but fully switching to d_interval/v_interval needs bigger surgery.
tacaswell
approved these changes
Jun 24, 2019
efiring
approved these changes
Jun 24, 2019
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Jun 25, 2019
ivanov
added a commit
that referenced
this pull request
Jun 25, 2019
…579-on-v3.1.x Backport PR #14579 on branch v3.1.x (Fix inversion of 3d axis.)
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... which was broken because 3d axises stored and accessed their viewlim
info sometimes in xy_viewLim/zz_viewLim and sometimes in v_interval (and
likewise for datalim), leading to out-of-sync info...
Not deprecating d_interval/v_interval for now both because this needs to
go to 3.1.1 to fix the breakage and because I think storing the info in
axis attributes actually makes more sense than in viewLim/dataLim --
but fully switching to d_interval/v_interval needs bigger surgery.
Closes #14577.
edit: now with tests.
PR Summary
PR Checklist