Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix text kerning calculations and some FT2Font cleanup #14940

Merged
merged 6 commits into from
Aug 23, 2019
Merged

Fix text kerning calculations and some FT2Font cleanup #14940

merged 6 commits into from
Aug 23, 2019

Commits on Aug 23, 2019

  1. Cleanup some unnecessary FT2Font class members.

    @QuLogic
    QuLogic committed Aug 23, 2019
    Configuration menu
    Copy the full SHA
    91ec958 View commit details
    Browse the repository at this point in the history

  2. Fix minor typo in kerning example.

    @QuLogic
    QuLogic committed Aug 23, 2019
    Configuration menu
    Copy the full SHA
    a8bb386 View commit details
    Browse the repository at this point in the history

  3. Use slightly more correct types for FreeType.

    @QuLogic
    QuLogic committed Aug 23, 2019
    Configuration menu
    Copy the full SHA
    c404b9f View commit details
    Browse the repository at this point in the history

  4. Fix calculation of kerning values. 

    For the straight `get_kerning` call, the result should be in subpixels,
since the callers (in Python) correctly scale it by 64 themselves.

For the glyph advancement calculation, both `pen` (used for glyph
transform and with content boxes) and kerning are in 26.6 fractional
pixels.

Therefore, there's no need to scale either case by 2**6 (64).
    @QuLogic
    QuLogic committed Aug 23, 2019
    Configuration menu
    Copy the full SHA
    7f57740 View commit details
    Browse the repository at this point in the history

  5. Add an rcParam to restore old kerning behaviour. 

    This is enabled for the classic test style, so that the 100 or so old
images do not need to be regenerated.
    @QuLogic
    QuLogic committed Aug 23, 2019
    Configuration menu
    Copy the full SHA
    a1df646 View commit details
    Browse the repository at this point in the history

  6. Add what's new entry about fixed kerning.

    @QuLogic
    QuLogic committed Aug 23, 2019
    Configuration menu
    Copy the full SHA
    f10da0c View commit details
    Browse the repository at this point in the history