Backport Python 3 fixes on branch v2.2.x #14964
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QuLogic
force-pushed
the
auto-backport-of-pr-14649-on-v2.2.x
branch
from
0ab5f49
to
54f6cc0
Compare
QuLogic
force-pushed
the
auto-backport-of-pr-14649-on-v2.2.x
branch
2 times, most recently
from
05577e0
to
28b7010
Compare
The `message` parameter is actually the message to print when it fails, but we want to check the exception message, which is the `match` parameter.
This way, we can still see that Python 3 is working, without disabling fast finish. There's still more work to be done to fix Python 2.
QuLogic
force-pushed
the
auto-backport-of-pr-14649-on-v2.2.x
branch
from
28b7010
to
66c9dfa
Compare
QuLogic
changed the title
|
This should fix Python 3 on AppVeyor, but there are more difficulties with Python 2. I moved that to the last build, so we can at least get results for 3 but also keep fast finish on. |
anntzer
approved these changes
Aug 8, 2019
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport PR #14649: Fix appveyor conda py37