Various backend cleanups. #15211
Merged
Various backend cleanups. #15211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timhoffm
reviewed
Sep 7, 2019
| @@ -963,14 +963,12 @@ def get_renderer(self): | |||
| return RendererPgf(self.figure, None, dummy=True) | |||
|
|
|||
|
|
|||
| class FigureManagerPgf(FigureManagerBase): | |||
| pass | |||
| FigureManagerPgf = FigureManagerBase | |||
There was a problem hiding this comment.
I wouldn't do this because you don't create a FigureManagerPgf type with that, so that
>>> mgr = FigureManagerPgf()
>>> type(mgr)
<class 'FigureManagerBase'>
which is a bit confusing.
There was a problem hiding this comment.
this is consistent with FigureManagerPS, FigureManagerPDF and FigureManagerSVG, and was discussed in #9551 (review).
There was a problem hiding this comment.
Still not convinced this is a good approach, but accepting as precedenced.
timhoffm
approved these changes
Sep 7, 2019
QuLogic
approved these changes
Mar 14, 2020
- Noninteractive backends don't need to redefine `draw()` as a do-nothing: that's already the default in the base class. - The pgf backend manager can just be an alias for FigureManagerBase: this is consistent with the other noninteractive backends. - FigureCanvasQT doesn't need to assign `self.figure = figure`: that's already done in the super() init. - Use star-unpack in backend_template. - The list of event handlers set up by backend_wx is much bigger than previously documented.
anntzer
force-pushed
the
backends_cleanups
branch
from
a7223c8
to
4a9f6a8
Compare
|
rebased |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
draw()as ado-nothing: that's already the default in the base class.
self.figure = figure:that's already done in the super() init.
previously documented.
PR Summary
PR Checklist