Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use correct pip/pytest on azure #15418

Merged
merged 2 commits into from Oct 22, 2019
Merged

Conversation

dstansby
Copy link
Member

This is the same as #15300, but the Azure build seems to have disappeared from that PR so this is just to see what the build error is (and maybe fix it).

@dstansby
Copy link
Member Author

Progress: installing numpy first has moved the error to pillow needing to be compiled, but not finding the installed copy of zlib.

@tacaswell
Copy link
Member

@tacaswell
Copy link
Member

Looking at pillow's CI, they use appveyor and have a somewhat complicated set of scripts to set up the build enviroment.

It looks like there are already py38 wheels available (https://www.lfd.uci.edu/~gohlke/pythonlibs/#pillow) but I am not sure the best way to get that installed.

@dstansby
Copy link
Member Author

The other option is if we don't need to save compressed PNGs we could in theory disable the need for zlib: https://pillow.readthedocs.io/en/latest/installation.html#external-libraries

@dstansby
Copy link
Member Author

Perhaps another option is to do the python preview testing on Linux, where hopefully it will be easier to deal with the pillow compilation requirements?

@tacaswell
Copy link
Member

We should run it on both ;)

Hopefully the patch release pre-releases will be easier to manage (as the wheels from the 3.8.0 should still work)

@anntzer
Copy link
Contributor

anntzer commented Oct 15, 2019

@tacaswell re: chris gohlke's windows wheels: for mplcairo (where I need the cairocffi wheel for the windows build) I just downloaded manually chris' wheel and mirrored it myself https://github.com/anntzer/cairocffi-windows-wheels https://github.com/matplotlib/mplcairo/blob/144388bf94d4cfb8010e835ae5c3e13643533354/azure-pipelines.yml#L53

Not depending on zlib was intentional in #15193 -- I'm effectively relying on Pillow windows wheels being available.

@tacaswell
Copy link
Member

Can we not install zlib at all then?

@anntzer
Copy link
Contributor

anntzer commented Oct 16, 2019

that's the intent of #15378.

@tacaswell tacaswell modified the milestones: v3.2.0, v3.3.0 Oct 19, 2019
@tacaswell
Copy link
Member

The mac fix went in via #15429 and a hacky way of skipping 38 on azure came in via #15447 .

@tacaswell tacaswell merged commit 6cd7419 into matplotlib:master Oct 22, 2019
@dstansby dstansby deleted the azure-test branch October 22, 2019 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants