Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rely on findfont autofallback-to-default in pdf/ps backends. #15673

Merged
merged 1 commit into from Nov 22, 2019

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Nov 11, 2019

findfont(...) will never return None unless fallback_to_default=False
is passed -- the default is True and causes afm searches to fall
back to Helvetica -- so the "filename is None" branch never occurs.
(The code in the pdf/ps backends came in in af9954d (2009) whereas
fallback_to_default only came in in 94120dc (2010).)

Noted while reviewing #15629.

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

findfont(...) will never return None unless fallback_to_default=False
is passed -- the default is True and causes afm searches to fall
back to Helvetica -- so the "filename is None" branch never occurs.
(The code in the pdf/ps backends came in in af9954d (2009) whereas
fallback_to_default only came in in 94120dc (2010).)
@timhoffm timhoffm added this to the v3.3.0 milestone Nov 17, 2019
@dstansby dstansby merged commit 49d111c into matplotlib:master Nov 22, 2019
@anntzer anntzer deleted the unfindfont branch November 22, 2019 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants