Mac OS X 10.5 needs an autoreleasepool here to avoid memory leaks. Newer... #1587

Merged
merged 1 commit into from Dec 19, 2012

Conversation

Projects
None yet
4 participants
Contributor

mdehoon commented Dec 11, 2012

... versions of Mac OS X do not, but it doesn't hurt to have one anyway. Without the autorelease pool, on Mac OS X 10.5 show() leaks memory and the OS prints error messages.

Mac OS X 10.5 needs an autoreleasepool here to avoid memory leaks. Ne…
…wer versions of Mac OS X do not, but it doesn't hurt to have one anyway.
Member

pelson commented Dec 11, 2012

👍

Owner

mdboom commented Dec 11, 2012

I'm not a Mac user, but maybe it would be helpful to have a script to reproduce the leak in the unit directory (where we have some other memory leaking stuff).

Contributor

mdehoon commented Dec 12, 2012

Well it's a bit of a trivial leak, which only shows up on particular versions of Mac OS X; if it does show up, it is obvious since the OS prints out warning messages. Also this memory leak is independent of Python's garbage collector. So I think we can do without a specific test for this.

Contributor

mdehoon commented Dec 19, 2012

Could somebody please accept this pull request? Then I can move on to the other open bugs.

WeatherGod added a commit that referenced this pull request Dec 19, 2012

Merge pull request #1587 from mdehoon/fix-show-memoryleak
Mac OS X 10.5 needs an autoreleasepool here to avoid memory leaks. Newer...

@WeatherGod WeatherGod merged commit 9c60c58 into matplotlib:master Dec 19, 2012

1 check passed

default The Travis build passed
Details
Contributor

mdehoon commented Dec 20, 2012

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment