Mac OS X 10.5 needs an autoreleasepool here to avoid memory leaks. Newer... #1587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…wer versions of Mac OS X do not, but it doesn't hurt to have one anyway.
|
👍 |
|
I'm not a Mac user, but maybe it would be helpful to have a script to reproduce the leak in the |
|
Well it's a bit of a trivial leak, which only shows up on particular versions of Mac OS X; if it does show up, it is obvious since the OS prints out warning messages. Also this memory leak is independent of Python's garbage collector. So I think we can do without a specific test for this. |
|
Could somebody please accept this pull request? Then I can move on to the other open bugs. |
WeatherGod
added a commit
that referenced
this pull request
Dec 19, 2012
Mac OS X 10.5 needs an autoreleasepool here to avoid memory leaks. Newer...
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... versions of Mac OS X do not, but it doesn't hurt to have one anyway. Without the autorelease pool, on Mac OS X 10.5 show() leaks memory and the OS prints error messages.