Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TST: test_fork: Missing join #16126

Merged
merged 1 commit into from Jan 7, 2020
Merged

TST: test_fork: Missing join #16126

merged 1 commit into from Jan 7, 2020

Conversation

Kojoley
Copy link
Member

@Kojoley Kojoley commented Jan 6, 2020

Probably this is a cause of test_fork taking forever to complete sometimes.

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@Kojoley
TST: test_fork: Missing join
f1308bc 
Probably this is a cause of `test_fork` taking forever to complete sometimes.
@Kojoley Kojoley mentioned this pull request Jan 6, 2020
Closed
@QuLogic QuLogic requested a review from anntzer January 7, 2020 00:46
@QuLogic QuLogic added this to the v3.1.3 milestone Jan 7, 2020
anntzer
anntzer approved these changes Jan 7, 2020
View reviewed changes
Copy link
Contributor

@anntzer anntzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't know if this will help, but it does look more correct for sure.

@anntzer anntzer merged commit 68d5e2f into matplotlib:master Jan 7, 2020
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Jan 7, 2020
@anntzer @meeseeksmachine
Backport PR matplotlib#16126: TST: test_fork: Missing join
538fb76
This was referenced Jan 7, 2020
Merged
Merged
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Jan 7, 2020
@anntzer @meeseeksmachine
Backport PR matplotlib#16126: TST: test_fork: Missing join
5335c4e
@Kojoley Kojoley deleted the tst-test_fork-missing-join branch January 7, 2020 13:13
Kojoley added a commit that referenced this pull request Jan 7, 2020
@Kojoley @anntzer
Backport PR #16126 on branch v3.2.x (TST: test_fork: Missing j… (#16132)
161219a 
Backport PR #16126 on branch v3.2.x (TST: test_fork: Missing join)

Co-authored-by: Antony Lee <anntzer.lee@gmail.com>
Kojoley added a commit that referenced this pull request Jan 7, 2020
@Kojoley @anntzer
Backport PR #16126 on branch v3.1.x (TST: test_fork: Missing j… (#16131)
00633ae 
Backport PR #16126 on branch v3.1.x (TST: test_fork: Missing join)

Co-authored-by: Antony Lee <anntzer.lee@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QuLogic QuLogic QuLogic approved these changes

@anntzer anntzer anntzer approved these changes

Assignees
No one assigned
Labels
topic: testing topic: text/fonts
Projects
None yet
Milestone
v3.1.3
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Kojoley @QuLogic @anntzer