STY: Fix underindented continuation lines. #16279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anntzer
commented
Jan 21, 2020
| # need to change the orientation. | ||
| self._locstrings = self._locstrings[::-1] | ||
| elif align != self._locstrings[0]: | ||
| raise ValueError('"{}" is not a valid axis orientation, ' |
There was a problem hiding this comment.
the logic here was incorrect (we already checked that align in self._locstrings).
anntzer
force-pushed
the
e128
branch
2 times, most recently
from
dfee54c
to
4f5cfdb
Compare
timhoffm
reviewed
Jan 26, 2020
anntzer
force-pushed
the
e128
branch
2 times, most recently
from
14bc3ee
to
ab61a38
Compare
timhoffm
approved these changes
Jan 26, 2020
|
rebased |
I don't agree with *all* indent choices of pycodestyle but these look mostly like improvements.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't agree with all indent choices of pycodestyle but these look
mostly like improvements.
Not doing the corresponding fix for overindented lines because I think PyCQA/pycodestyle#569 needs to be fixed first.
PR Summary
PR Checklist