Add set/get for ellipse width/height #16395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anntzer
reviewed
Feb 3, 2020
|
Tests are failing. |
timhoffm
reviewed
Feb 4, 2020
There was a problem hiding this comment.
Thanks for the PR. Overall, this looks good!
Please fix the style issues indicated by flake8:
./lib/matplotlib/patches.py:1453:1: D300 Use """triple double quotes"""
./lib/matplotlib/patches.py:1455:1: W293 blank line contains whitespace
./lib/matplotlib/patches.py:1462:1: W293 blank line contains whitespace
./lib/matplotlib/patches.py:1464:1: D300 Use """triple double quotes"""
./lib/matplotlib/patches.py:1468:1: W293 blank line contains whitespace
./lib/matplotlib/patches.py:1470:1: W293 blank line contains whitespace
./lib/matplotlib/patches.py:1472:1: D300 Use """triple double quotes"""
./lib/matplotlib/patches.py:1474:1: W293 blank line contains whitespace
./lib/matplotlib/patches.py:1481:1: W293 blank line contains whitespace
./lib/matplotlib/patches.py:1483:1: D300 Use """triple double quotes"""
./lib/matplotlib/patches.py:1487:1: W293 blank line contains whitespace
./lib/matplotlib/patches.py:1490:1: E302 expected 2 blank lines, found 1
lib/matplotlib/patches.py
Outdated
| @@ -1449,6 +1449,43 @@ def get_center(self): | |||
|
|
|||
| center = property(get_center, set_center) | |||
|
|
|||
| def set_width(self, width): | |||
| ''' | |||
| Set the width of the ellipse | |||
There was a problem hiding this comment.
Suggested change
| Set the width of the ellipse | |
| Set the width of the ellipse. |
Please finish the sentences with a period (following PEP-257) - also in the other methods. I know, there are some missing in the current docs, but we try to move towards a more consistent doc style.
|
Let me add the ellipse angle as well before merging the PR |
Codecov Report
@@ Coverage Diff @@
## master #16395 +/- ##
==========================================
- Coverage 80.85% 80.78% -0.07%
==========================================
Files 307 307
Lines 75745 75767 +22
Branches 9690 9692 +2
==========================================
- Hits 61245 61211 -34
- Misses 11961 12012 +51
- Partials 2539 2544 +5
Continue to review full report at Codecov.
|
timhoffm
approved these changes
Feb 5, 2020
dstansby
approved these changes
Feb 7, 2020
|
Thanks for your first contribution to Matplotlib 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Add methods to set/get the width/height for Ellipse Patches.
Mostly the setter methods are interesting, as they set
self.stale=Trueto force redrawing the patch at the next plot call.I used those methods for interactive plotting, they have similar use than the existing
set_center.The
stale=Truewas not be obvious to update the shape size interactively so I think the method could benefit others.PR Checklist